herald-for-android

Projects that follow the best practices below can voluntarily self-certify and show that they've achieved an Open Source Security Foundation (OpenSSF) best practices badge.

If this is your project, please show your badge status on your project page! The badge status looks like this: Badge level for project 4869 is passing Here is how to embed it:

These are the Passing level criteria. You can also view the Silver or Gold level criteria.

        

 Basics 13/13

  • Identification

    Herald for Android - Reliable mobile Bluetooth communications - Android library & test app

    What programming language(s) are used to implement the project?
  • Basic project website content


    The project website MUST succinctly describe what the software does (what problem does it solve?). [description_good]

    The project website MUST provide information on how to: obtain, provide feedback (as bug reports or enhancements), and contribute to the software. [interact]

    Obtain: https://heraldprox.io/download Provide feedback/Contribute: https://heraldprox.io/community Repo also has a contributing.md file



    The information on how to contribute MUST explain the contribution process (e.g., are pull requests used?) (URL required) [contribution]

    The information on how to contribute SHOULD include the requirements for acceptable contributions (e.g., a reference to any required coding standard). (URL required) [contribution_requirements]

    https://heraldprox.io/contribute - Contributor's guide (being created today and uploaded. Should be available from Monday 17th May 2021)


  • FLOSS license

    What license(s) is the project released under?



    The software produced by the project MUST be released as FLOSS. [floss_license]

    The Apache-2.0 license is approved by the Open Source Initiative (OSI).



    It is SUGGESTED that any required license(s) for the software produced by the project be approved by the Open Source Initiative (OSI). [floss_license_osi]

    The Apache-2.0 license is approved by the Open Source Initiative (OSI).



    The project MUST post the license(s) of its results in a standard location in their source repository. (URL required) [license_location]
  • Documentation


    The project MUST provide basic documentation for the software produced by the project. [documentation_basics]

    Project documentation guide (multiple repo project).

    Developers/Integration guide: https://heraldprox.io/guide/



    The project MUST provide reference documentation that describes the external interface (both input and output) of the software produced by the project. [documentation_interface]

    Design guide: https://heraldprox.io/design/ Herald formal Standards guides: https://heraldprox.io/specs/

    We also work with ETSI and others on international standards.


  • Other


    The project sites (website, repository, and download URLs) MUST support HTTPS using TLS. [sites_https]

    Given only https: URLs.



    The project MUST have one or more mechanisms for discussion (including proposed changes and issues) that are searchable, allow messages and topics to be addressed by URL, enable new people to participate in some of the discussions, and do not require client-side installation of proprietary software. [discussion]

    GitHub supports discussions on issues and pull requests.

    There's is also an LFPH Slack instance with herald-* named channels. https://slack.lfph.io/



    The project SHOULD provide documentation in English and be able to accept bug reports and comments about code in English. [english]

    The project MUST be maintained. [maintained]

    Herald is a Tier 2 (soon Tier 3) Project within the Linux Foundation Public Health (LFPH). This requires minimum standards for community size. Submitter is the TSC Chair for 2021-2022.



(Advanced) What other users have additional rights to edit this badge entry? Currently: []



It's a suite of project repositories with a common goal: Reliable presence detection, distance estimation, and data transfer between devices. This is aimed at providing eHealth approaches and benefits, both through Digital Contact Tracing (DCT) but also in helping other eHealth areas, including more efficient hospital operations.

  • Public version-controlled source repository


    The project MUST have a version-controlled source repository that is publicly readable and has a URL. [repo_public]

    Repository on GitHub, which provides public git repositories with URLs.



    The project's source repository MUST track what changes were made, who made the changes, and when the changes were made. [repo_track]

    Repository on GitHub, which uses git. git can track the changes, who made them, and when they were made.



    To enable collaborative review, the project's source repository MUST include interim versions for review between releases; it MUST NOT include only final releases. [repo_interim]

    We have -beta1/ beta2 semver tags for intermediate releases. We have a public develop branch, and a public master/main branch with v tags for releases from either (depending on whether they are interim releases or not).



    It is SUGGESTED that common distributed version control software be used (e.g., git) for the project's source repository. [repo_distributed]

    Repository on GitHub, which uses git. git is distributed.


  • Unique version numbering


    The project results MUST have a unique version identifier for each release intended to be used by users. [version_unique]

    It is SUGGESTED that the Semantic Versioning (SemVer) or Calendar Versioning (CalVer) version numbering format be used for releases. It is SUGGESTED that those who use CalVer include a micro level value. [version_semver]


    It is SUGGESTED that projects identify each release within their version control system. For example, it is SUGGESTED that those using git identify each release using git tags. [version_tags]

    We use v* tags. E.g. v1.0, v1.2-beta1


  • Release notes


    The project MUST provide, in each release, release notes that are a human-readable summary of major changes in that release to help users determine if they should upgrade and what the upgrade impact will be. The release notes MUST NOT be the raw output of a version control log (e.g., the "git log" command results are not release notes). Projects whose results are not intended for reuse in multiple locations (such as the software for a single website or service) AND employ continuous delivery MAY select "N/A". (URL required) [release_notes]

    The release notes MUST identify every publicly known run-time vulnerability fixed in this release that already had a CVE assignment or similar when the release was created. This criterion may be marked as not applicable (N/A) if users typically cannot practically update the software themselves (e.g., as is often true for kernel updates). This criterion applies only to the project results, not to its dependencies. If there are no release notes or there have been no publicly known vulnerabilities, choose N/A. [release_notes_vulns]

    We don't publish a release if there is a known vulnerability to our code.


  • Bug-reporting process


    The project MUST provide a process for users to submit bug reports (e.g., using an issue tracker or a mailing list). (URL required) [report_process]

    https://github.com/theheraldproject/herald-for-android/issues

    We also provide templates for issues/features.



    The project SHOULD use an issue tracker for tracking individual issues. [report_tracker]

    The project MUST acknowledge a majority of bug reports submitted in the last 2-12 months (inclusive); the response need not include a fix. [report_responses]


    The project SHOULD respond to a majority (>50%) of enhancement requests in the last 2-12 months (inclusive). [enhancement_responses]

    We aim to respond within 5 days



    The project MUST have a publicly available archive for reports and responses for later searching. (URL required) [report_archive]
  • Vulnerability report process


    The project MUST publish the process for reporting vulnerabilities on the project site. (URL required) [vulnerability_report_process]

    As per SECURITY.md file. The Linux Foundation Public Health currently does not have a standard policy or reporting mechanism (E.g. HackerOne) which we can use. I've raised this as an issue for the next TAC meeting. https://github.com/theheraldproject/herald-for-android/blob/develop/SECURITY.md



    If private vulnerability reports are supported, the project MUST include how to send the information in a way that is kept private. (URL required) [vulnerability_report_private]

    As per SECURITY.md file. The Linux Foundation Public Health currently does not have a standard policy or reporting mechanism (E.g. HackerOne) which we can use. I've raised this as an issue for the next TAC meeting.



    The project's initial response time for any vulnerability report received in the last 6 months MUST be less than or equal to 14 days. [vulnerability_report_response]

    We respond to all issue reports within 5 days. We have issued security patches in the past within 24 hours: https://github.com/theheraldproject/herald-for-android/releases/tag/v1.1.1


  • Working build system


    If the software produced by the project requires building for use, the project MUST provide a working build system that can automatically rebuild the software from source code. [build]

    Gradle build system for local (developer, adopter) and automated CI (project release via GitHub Actions) builds



    It is SUGGESTED that common tools be used for building the software. [build_common_tools]

    We use GitHub Actions and GitHub Packages where possible. We also use the appropriate packaging approach for each system (E.g. Maven Central for this Android repo)



    The project SHOULD be buildable using only FLOSS tools. [build_floss_tools]

    Gradle builds. Maven packages.


  • Automated test suite


    The project MUST use at least one automated test suite that is publicly released as FLOSS (this test suite may be maintained as a separate FLOSS project). The project MUST clearly show or document how to run the test suite(s) (e.g., via a continuous integration (CI) script or via documentation in files such as BUILD.md, README.md, or CONTRIBUTING.md). [test]

    Standard approach via gradle test. Branch protection rules for this to be ran for every PR to the develop or master/main branches.



    A test suite SHOULD be invocable in a standard way for that language. [test_invocation]

    Gradle



    It is SUGGESTED that the test suite cover most (or ideally all) the code branches, input fields, and functionality. [test_most]

    Currently covers all core library features. Elements requiring 2 device Bluetooth communication cannot be tested with unit tests, but we have a manual mechanism for this too. We abstract as much into classes as possible so there's little to test physically outside of unit tests.



    It is SUGGESTED that the project implement continuous integration (where new or changed code is frequently integrated into a central code repository and automated tests are run on the result). [test_continuous_integration]

    GitHub Actions has just been implemented.


  • New functionality testing


    The project MUST have a general policy (formal or not) that as major new functionality is added to the software produced by the project, tests of that functionality should be added to an automated test suite. [test_policy]

    This is a standard policy. We require developers to use Test Driven Development.



    The project MUST have evidence that the test_policy for adding tests has been adhered to in the most recent major changes to the software produced by the project. [tests_are_added]

    We have just implemented a GitHub CI system that archives the test output HTML for every test as an artifact for each build (which is required for every single PR now). This is new though. There is a major (v2.0) version being released in the coming days adhering to this that all repos will adopt.



    It is SUGGESTED that this policy on adding tests (see test_policy) be documented in the instructions for change proposals. [tests_documented_added]

    It is documented in the new Contributor's guide (published 17 May 2021): https://heraldprox.io/contribute


  • Warning flags


    The project MUST enable one or more compiler warning flags, a "safe" language mode, or use a separate "linter" tool to look for code quality errors or common simple mistakes, if there is at least one FLOSS tool that can implement this criterion in the selected language. [warnings]

    gradle lint is used



    The project MUST address warnings. [warnings_fixed]

    Every major release requires that all warnings are addressed, or documented and ignores with a link to the documentation where the ignore instruction is present. (Not applicable for Android, but the Zephyr C++ build system has such warnings, which is well known in that community).



    It is SUGGESTED that projects be maximally strict with warnings in the software produced by the project, where practical. [warnings_strict]

    For the Android/Java project this is done.


  • Secure development knowledge


    The project MUST have at least one primary developer who knows how to design secure software. (See ‘details’ for the exact requirements.) [know_secure_design]

    Myself (Adam Fowler) in the core committer team and as TSC Chair has this knowledge. Other contributors (not committers) do too.



    At least one of the project's primary developers MUST know of common kinds of errors that lead to vulnerabilities in this kind of software, as well as at least one method to counter or mitigate each of them. [know_common_errors]

    I (Adam Fowler) has experience of this from industry, including OWASP and mobile application scanning tools. I am also familiar with NCSC secure coding requirements.


  • Use basic good cryptographic practices

    Note that some software does not need to use cryptographic mechanisms. If your project produces software that (1) includes, activates, or enables encryption functionality, and (2) might be released from the United States (US) to outside the US or to a non-US-citizen, you may be legally required to take a few extra steps. Typically this just involves sending an email. For more information, see the encryption section of Understanding Open Source Technology & US Export Controls.

    The software produced by the project MUST use, by default, only cryptographic protocols and algorithms that are publicly published and reviewed by experts (if cryptographic protocols and algorithms are used). [crypto_published]

    RandomSource supports various options. We use the SecureRandom's backup option as we have to support old phones (Dating back to 2010) and old versions of Android that would otherwise block indefinitely, leading to poor epidemiological efficacy for older phones (and thus would disproportionately negatively effect poorer people). See these classes for examples of security steps taken:- - https://github.com/theheraldproject/herald-for-android/tree/develop/herald/src/main/java/io/heraldprox/herald/sensor/datatype/random - https://github.com/theheraldproject/herald-for-android/blob/develop/herald/src/main/java/io/heraldprox/herald/sensor/datatype/PseudoDeviceAddress.java - https://github.com/theheraldproject/herald-for-android/blob/develop/herald/src/main/java/io/heraldprox/herald/sensor/payload/simple/K.java



    If the software produced by the project is an application or library, and its primary purpose is not to implement cryptography, then it SHOULD only call on software specifically designed to implement cryptographic functions; it SHOULD NOT re-implement its own. [crypto_call]

    We use provided cryptography where possible. There is a need in next version of the project to implement our own handshake and token mechanism to prevent relay and replay attacks over the wire. That will use DH and TOTP as a basis though. Initial design can be seen here: https://heraldprox.io/specs/payload-secured



    All functionality in the software produced by the project that depends on cryptography MUST be implementable using FLOSS. [crypto_floss]

    Both our library and any dependencies will be Apache-2.0. OpenJDK implementations of core crypto features are available for Java primitives.



    The security mechanisms within the software produced by the project MUST use default keylengths that at least meet the NIST minimum requirements through the year 2030 (as stated in 2012). It MUST be possible to configure the software so that smaller keylengths are completely disabled. [crypto_keylength]

    Met where applicable. Library adopters can configure a range of options, and plug in their own where needed.



    The default security mechanisms within the software produced by the project MUST NOT depend on broken cryptographic algorithms (e.g., MD4, MD5, single DES, RC4, Dual_EC_DRBG), or use cipher modes that are inappropriate to the context, unless they are necessary to implement an interoperable protocol (where the protocol implemented is the most recent version of that standard broadly supported by the network ecosystem, that ecosystem requires the use of such an algorithm or mode, and that ecosystem does not offer any more secure alternative). The documentation MUST describe any relevant security risks and any known mitigations if these broken algorithms or modes are necessary for an interoperable protocol. [crypto_working]

    We follow NIST SP recommendations and NCSC recommendations.



    The default security mechanisms within the software produced by the project SHOULD NOT depend on cryptographic algorithms or modes with known serious weaknesses (e.g., the SHA-1 cryptographic hash algorithm or the CBC mode in SSH). [crypto_weaknesses]

    We do this where possible but we don't always use the very latest approaches. This is because, uniquely, we have to support platforms back to iOS 9.3 and Android SDK 21 in order to be widely usable on a very wide range of mobile devices so that poorer communities have access to life saving technology in our Digital Contact Tracing and eHealth solutions. Where a 'lowest common denominator' approach is used, we ensure that adopters can switch in/out a more secure provided algorithm, or replace it with their own algorithm. This allows us to provide maximum reach and recommend best practice without disadvantaging poor communities.



    The security mechanisms within the software produced by the project SHOULD implement perfect forward secrecy for key agreement protocols so a session key derived from a set of long-term keys cannot be compromised if one of the long-term keys is compromised in the future. [crypto_pfs]

    This is the preferred approach but in an anonymous system there are limits to what can be achieved. E.g. for the 'simple payload' a daily key is used to forward generate the 5 minute expiring 'ephemeral keys' for digital contact tracing. This is a 'good thing', as less information needs to be transmitted across mobile networks for devices to realise they have had exposure to an ill person. The identity behind this daily key is not known, and only transmitted to devices after the event and after individuals have been diagnosed. (This is the same way GAEN works). A new Secured Payload will provide this mechanism in a different way. This will use 'tokens' issued over an encrypted mechanism where this token is only exchanged with that device. This will be generated in such a way as to provide for perfect forward secrecy. (There will not be a common key basis to each token).



    If the software produced by the project causes the storing of passwords for authentication of external users, the passwords MUST be stored as iterated hashes with a per-user salt by using a key stretching (iterated) algorithm (e.g., Argon2id, Bcrypt, Scrypt, or PBKDF2). See also OWASP Password Storage Cheat Sheet. [crypto_password_storage]

    We don't store secrets. Where key storage features are used, we delegate this to the host OS. (E.g. it's managed in their secure enclaves, where available).



    The security mechanisms within the software produced by the project MUST generate all cryptographic keys and nonces using a cryptographically secure random number generator, and MUST NOT do so using generators that are cryptographically insecure. [crypto_random]

    Used where provided by the host device. Where enough entropy is not provided (old Android phones), an external source of additional entropy is used to change the random bytes generated.


  • Secured delivery against man-in-the-middle (MITM) attacks


    The project MUST use a delivery mechanism that counters MITM attacks. Using https or ssh+scp is acceptable. [delivery_mitm]

    Source code: https and git+ssh source access. Builds on GitHub actions natively. Bluetooth transfer: Only certain approaches possible with completely anonymous data exchange. New Secured Payload will issue tokens and hash responses from devices, so even if the originating transfer is MITM'ed, the resultant 'exposure' data would fail to be authenticated.



    A cryptographic hash (e.g., a sha1sum) MUST NOT be retrieved over http and used without checking for a cryptographic signature. [delivery_unsigned]

    Not done in our project


  • Publicly known vulnerabilities fixed


    There MUST be no unpatched vulnerabilities of medium or higher severity that have been publicly known for more than 60 days. [vulnerabilities_fixed_60_days]

    No confirmed vulnerabilities. All security mechanisms can also be replaced / switched out by downstream adopters of the library to more secure versions. Due to the wide range of android (SDK 21) and iOS (9.3+) devices we have to support, some options are more secure than others, but adopters can choose their preferred approach for all security functions.



    Projects SHOULD fix all critical vulnerabilities rapidly after they are reported. [vulnerabilities_critical_fixed]

    Only time this has been necessary the fix was issued within 24 hours of the project team being notified.


  • Other security issues


    The public repositories MUST NOT leak a valid private credential (e.g., a working password or private key) that is intended to limit public access. [no_leaked_credentials]

    GitHub secrets are used for the build pipeline. No repository contains secrets, usernames, or passwords.


  • Static code analysis


    At least one static code analysis tool (beyond compiler warnings and "safe" language modes) MUST be applied to any proposed major production release of the software before its release, if there is at least one FLOSS tool that implements this criterion in the selected language. [static_analysis]

    Spotbugs now part of the unit_test GitHub Actions workflow, and ran on every PR to the develop or master/main branches as a pre-requisite check. This check also applies to administrators and cannot be bypassed.



    It is SUGGESTED that at least one of the static analysis tools used for the static_analysis criterion include rules or approaches to look for common vulnerabilities in the analyzed language or environment. [static_analysis_common_vulnerabilities]

    Spotbugs now part of the unit_test GitHub Actions workflow, and ran on every PR to the develop or master/main branches as a pre-requisite check. This check also applies to administrators and cannot be bypassed. We also use the findsecbugs plugin to spotbugs.



    All medium and higher severity exploitable vulnerabilities discovered with static code analysis MUST be fixed in a timely way after they are confirmed. [static_analysis_fixed]

    A PR cannot be merged without tests passing, including static analysis (as of today). Standard issue report fix (E.g. new vulns, old code) have a target SLA of 5 days.



    It is SUGGESTED that static source code analysis occur on every commit or at least daily. [static_analysis_often]

    We use gitflow so commits happen on forks. Every PR though has these required. (I.e. a commit set cannot be merged without these passing).


  • Dynamic code analysis


    It is SUGGESTED that at least one dynamic analysis tool be applied to any proposed major production release of the software before its release. [dynamic_analysis]

    Not done today.



    It is SUGGESTED that if the software produced by the project includes software written using a memory-unsafe language (e.g., C or C++), then at least one dynamic tool (e.g., a fuzzer or web application scanner) be routinely used in combination with a mechanism to detect memory safety problems such as buffer overwrites. If the project does not produce software written in a memory-unsafe language, choose "not applicable" (N/A). [dynamic_analysis_unsafe]

    Java project.



    It is SUGGESTED that the project use a configuration for at least some dynamic analysis (such as testing or fuzzing) which enables many assertions. In many cases these assertions should not be enabled in production builds. [dynamic_analysis_enable_assertions]

    Not done today.



    All medium and higher severity exploitable vulnerabilities discovered with dynamic code analysis MUST be fixed in a timely way after they are confirmed. [dynamic_analysis_fixed]

    Dynamic analysis not done today.



This data is available under the Creative Commons Attribution version 3.0 or later license (CC-BY-3.0+). All are free to share and adapt the data, but must give appropriate credit. Please credit Adam Fowler and the OpenSSF Best Practices badge contributors.

Project badge entry owned by: Adam Fowler.
Entry created on 2021-05-16 11:32:31 UTC, last updated on 2021-06-01 08:12:17 UTC. Last achieved passing badge on 2021-06-01 08:12:17 UTC.

Back